Common Develocity injection script is used for Gradle experiments #671
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erichaagdev
force-pushed
the
erichaagdev/common-dv-init-script
branch
from
4c0abb9 to
850b179
Compare
|
Successful cross platform test run: https://github.com/gradle/gradle-enterprise-build-validation-scripts/actions/runs/11524907372 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the BVS to leverage the tried and true common Develocity injection script to configure Develocity.
The approach taken was to use the common injection script where possible and move any BVS-specific logic to a secondary init script which I've called
configure-build-validation.gradle. Both the common injection script and the BVS-specific script are applied to all Gradle invocations and are configured via system properties.By leveraging the common injection script, we can ensure we don't break injection functionality, which in the past has proven to be somewhat fragile.